From 80df644701c89c10fe876fc41e3f0c9348717ceb Mon Sep 17 00:00:00 2001 From: neingeist Date: Fri, 15 Jul 2016 17:55:54 +0200 Subject: [PATCH 1/3] libvirt-check-trim.py: handle no disks --- libvirt-check-trim.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libvirt-check-trim.py b/libvirt-check-trim.py index 0b0c73e..885365c 100644 --- a/libvirt-check-trim.py +++ b/libvirt-check-trim.py @@ -18,6 +18,10 @@ for domain in conn.listAllDomains(): xml = domain.XMLDesc() tree = objectify.fromstring(xml) + if not hasattr(tree.devices, 'disk'): + print('(has no disks)') + continue + # every disk should be scsi + discard=unmap for disk in tree.devices.disk: if disk.get('device') != 'disk': From 3cbf948d39c50fe1f7675c08dc9fdc786dc57177 Mon Sep 17 00:00:00 2001 From: neingeist Date: Fri, 15 Jul 2016 18:09:19 +0200 Subject: [PATCH 2/3] libvirt-check-trim.py: check machine type of vm --- libvirt-check-trim.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libvirt-check-trim.py b/libvirt-check-trim.py index 885365c..30a868a 100644 --- a/libvirt-check-trim.py +++ b/libvirt-check-trim.py @@ -18,6 +18,12 @@ for domain in conn.listAllDomains(): xml = domain.XMLDesc() tree = objectify.fromstring(xml) + machine = tree.os.type.get('machine') + if machine < 'pc-i440fx-2.1': + print('machine should be at least pc-i440fx-2.1') + # Might want to check qemu-system-x86_64 -M help for supported + # machines. + if not hasattr(tree.devices, 'disk'): print('(has no disks)') continue From 346f57be0026214deff04ef0ec79d017061ae570 Mon Sep 17 00:00:00 2001 From: neingeist Date: Fri, 15 Jul 2016 18:14:07 +0200 Subject: [PATCH 3/3] docker-check-updates: print line before each container --- docker-check-updates | 1 + 1 file changed, 1 insertion(+) diff --git a/docker-check-updates b/docker-check-updates index 7d1aefb..d627bbd 100755 --- a/docker-check-updates +++ b/docker-check-updates @@ -11,6 +11,7 @@ for container in c.containers(): id_ = container['Id'] image_id = c.inspect_container(id_)['Image'] + print('-' * 75) print('Container: {}'.format(name)) print('Image: {} '.format(image_id))