From 24c25b6fcde5303b73ab1014fd5a1f68b0a16088 Mon Sep 17 00:00:00 2001 From: Mike Gerber Date: Mon, 8 Jan 2024 19:30:20 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=8D=20mypy:=20Avoid=20using=20check()?= =?UTF-8?q?=20for=20all=20attr=20validators?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/dinglehopper/extracted_text.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/dinglehopper/extracted_text.py b/src/dinglehopper/extracted_text.py index 7ef9d1d..992b3a9 100644 --- a/src/dinglehopper/extracted_text.py +++ b/src/dinglehopper/extracted_text.py @@ -122,7 +122,7 @@ class ExtractedText: segment_id = attr.ib(type=Optional[str]) @segment_id.validator - def check(self, _, value): + def is_valid_segment_id(self, _, value): if value is None: return if not re.match(r"[\w\d_-]+", value): @@ -138,12 +138,12 @@ class ExtractedText: _grapheme_clusters = attr.ib(type=Optional[List[str]]) @segments.validator - def check(self, _, value): + def cant_set_both_segments_and_text(self, _, value): if value is not None and self._text is not None: raise ValueError("Can't have both segments and text") @joiner.validator - def check(self, _, value): + def is_valid_joiner(self, _, value): if self.segments is None: if value is not None: raise ValueError("Can't have joiner without segments to join") @@ -152,7 +152,7 @@ class ExtractedText: raise ValueError(f"Unexcepted segment joiner value {repr(value)}") @_text.validator - def check(self, _, value): + def is_valid_text(self, _, value): if value is None: return @@ -166,7 +166,7 @@ class ExtractedText: raise ValueError("Requires both text and grapheme clusters to be set") @_grapheme_clusters.validator - def check(self, _, value): + def are_valid_grapheme_clusters(self, _, value): if value is not None and self._text is None: raise ValueError("Requires both text and grapheme clusters to be set")