From a61c9356244275b79ae98f9eafd67016ebeb8359 Mon Sep 17 00:00:00 2001 From: "Gerber, Mike" Date: Fri, 12 Jun 2020 16:08:56 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20dinglehopper:=20Move=20Python=20?= =?UTF-8?q?3.5=20XXXs=20to=20a=20GitHub=20issue?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/qurator-spk/dinglehopper/issues/20. --- qurator/dinglehopper/ocr_files.py | 1 - qurator/dinglehopper/tests/test_integ_cli_valid_json.py | 2 -- qurator/dinglehopper/tests/test_integ_ocrd_cli.py | 2 -- 3 files changed, 5 deletions(-) diff --git a/qurator/dinglehopper/ocr_files.py b/qurator/dinglehopper/ocr_files.py index 2d88498..2ceebfd 100644 --- a/qurator/dinglehopper/ocr_files.py +++ b/qurator/dinglehopper/ocr_files.py @@ -16,7 +16,6 @@ import unicodedata class ExtractedText: segments = attr.ib() joiner = attr.ib(type=str) - # TODO Use type annotations for attr.ib types when support for Python 3.5 is dropped # TODO Types are not validated (attr does not do this yet) @property diff --git a/qurator/dinglehopper/tests/test_integ_cli_valid_json.py b/qurator/dinglehopper/tests/test_integ_cli_valid_json.py index 5699700..35421bb 100644 --- a/qurator/dinglehopper/tests/test_integ_cli_valid_json.py +++ b/qurator/dinglehopper/tests/test_integ_cli_valid_json.py @@ -10,7 +10,6 @@ from ..cli import process def test_cli_json(tmp_path): """Test that the cli/process() yields a loadable JSON report""" - # XXX Path.__str__() is necessary for Python 3.5 with working_directory(str(tmp_path)): with open('gt.txt', 'w') as gtf: gtf.write('AAAAA') @@ -26,7 +25,6 @@ def test_cli_json(tmp_path): def test_cli_json_cer_is_infinity(tmp_path): """Test that the cli/process() yields a loadable JSON report when CER == inf""" - # XXX Path.__str__() is necessary for Python 3.5 with working_directory(str(tmp_path)): with open('gt.txt', 'w') as gtf: gtf.write('') # Empty to yield CER == inf diff --git a/qurator/dinglehopper/tests/test_integ_ocrd_cli.py b/qurator/dinglehopper/tests/test_integ_ocrd_cli.py index 41da748..3d78f57 100644 --- a/qurator/dinglehopper/tests/test_integ_ocrd_cli.py +++ b/qurator/dinglehopper/tests/test_integ_ocrd_cli.py @@ -17,8 +17,6 @@ data_dir = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'data') def test_ocrd_cli(tmp_path): """Test OCR-D interface""" - # XXX Path.str() is necessary for Python 3.5 - # Copy test workspace test_workspace_dir_source = Path(data_dir) / 'actevedef_718448162' test_workspace_dir = tmp_path / 'test_ocrd_cli'