From 42d383920d7c8cd2cab435e93ecb78b7661e5c77 Mon Sep 17 00:00:00 2001 From: Sai Asish Y Date: Sun, 26 Jul 2026 18:29:07 -0700 Subject: [PATCH 1/3] return_deskew_slop: pass refined angles, not sigma_des, on landscape main page Signed-off-by: Sai Asish Y --- src/eynollah/utils/separate_lines.py | 2 +- tests/test_deskew.py | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 tests/test_deskew.py diff --git a/src/eynollah/utils/separate_lines.py b/src/eynollah/utils/separate_lines.py index 689a564..2fc65c4 100644 --- a/src/eynollah/utils/separate_lines.py +++ b/src/eynollah/utils/separate_lines.py @@ -1451,7 +1451,7 @@ def return_deskew_slop(img, angle, _ = best_angle(angles) angles = np.linspace(angle - 22.5, angle + 22.5, n_tot_angles) - angle, _ = best_angle(sigma_des) + angle, _ = best_angle(angles) elif main_page: #angles = np.linspace(-12, 12, n_tot_angles)#np.array([0 , 45 , 90 , -45]) angles = np.concatenate((np.linspace(-12, -7, n_tot_angles // 4), diff --git a/tests/test_deskew.py b/tests/test_deskew.py new file mode 100644 index 0000000..a2a8dc6 --- /dev/null +++ b/tests/test_deskew.py @@ -0,0 +1,12 @@ +import numpy as np + +from eynollah.utils.separate_lines import return_deskew_slop + +def test_deskew_landscape_main_page(): + # landscape page (width > height) used to crash with + # "TypeError: 'int' object is not iterable" (#223) + img = np.zeros((80, 160)) + for y in (20, 40, 60): + img[y:y + 3, 10:150] = 1 + angle = return_deskew_slop(img, 2, n_tot_angles=10, main_page=True) + assert np.isfinite(angle) From 027d6aaa268b5b85b3859b30e8e19a353ae9f5a7 Mon Sep 17 00:00:00 2001 From: kba Date: Tue, 28 Jul 2026 13:59:53 +0200 Subject: [PATCH 2/3] :memo: changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5ba551d..d6ad11b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,10 @@ Versioned according to [Semantic Versioning](http://semver.org/). ## Unreleased +Fixed: + + * `return_deskew_slop`: typo caused silent exit for landscape pages, #223, #224, ht @lazyants @SAY-5 + ## [0.9.1] - 2026-07-20 Fixed: From 15ddb7750e132462321a3d57b2a2b74cb8f2b151 Mon Sep 17 00:00:00 2001 From: kba Date: Tue, 28 Jul 2026 15:40:46 +0200 Subject: [PATCH 3/3] :package: v0.9.2 --- CHANGELOG.md | 3 +++ src/eynollah/ocrd-tool.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d6ad11b..0680b5d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ Versioned according to [Semantic Versioning](http://semver.org/). ## Unreleased +## [0.9.2] - 2026-07-28 + Fixed: * `return_deskew_slop`: typo caused silent exit for landscape pages, #223, #224, ht @lazyants @SAY-5 @@ -439,6 +441,7 @@ Fixed: Initial release +[0.9.2]: ../../compare/v0.9.2...v0.9.1 [0.9.1]: ../../compare/v0.9.1...v0.9.0 [0.9.0]: ../../compare/v0.9.0...v0.8.0 [0.8.0]: ../../compare/v0.8.0...v0.7.0 diff --git a/src/eynollah/ocrd-tool.json b/src/eynollah/ocrd-tool.json index b4b9be2..4f97386 100644 --- a/src/eynollah/ocrd-tool.json +++ b/src/eynollah/ocrd-tool.json @@ -1,5 +1,5 @@ { - "version": "0.9.0", + "version": "0.9.2", "git_url": "https://github.com/qurator-spk/eynollah", "dockerhub": "ocrd/eynollah", "tools": {