qurator-spk/dinglehopper
1
0
Fork 0
mirror of https://github.com/qurator-spk/dinglehopper.git synced 2025-07-01 14:40:00 +02:00
Code Issues Releases Wiki Activity

🔍 mypy: Avoid using check() for all attr validators

Browse source
This commit is contained in:
Mike Gerber 2024-01-08 19:30:20 +01:00
parent ac9d360dcd
commit 24c25b6fcd
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/dinglehopper/extracted_text.py
View file

@ -122,7 +122,7 @@ class ExtractedText:
segment_id = attr.ib(type=Optional[str]) segment_id = attr.ib(type=Optional[str])
@segment_id.validator @segment_id.validator
def check(self, _, value): def is_valid_segment_id(self, _, value):
if value is None: if value is None:
return return
if not re.match(r"[\w\d_-]+", value): if not re.match(r"[\w\d_-]+", value):
@ -138,12 +138,12 @@ class ExtractedText:
_grapheme_clusters = attr.ib(type=Optional[List[str]]) _grapheme_clusters = attr.ib(type=Optional[List[str]])
@segments.validator @segments.validator
def check(self, _, value): def cant_set_both_segments_and_text(self, _, value):
if value is not None and self._text is not None: if value is not None and self._text is not None:
raise ValueError("Can't have both segments and text") raise ValueError("Can't have both segments and text")
@joiner.validator @joiner.validator
def check(self, _, value): def is_valid_joiner(self, _, value):
if self.segments is None: if self.segments is None:
if value is not None: if value is not None:
raise ValueError("Can't have joiner without segments to join") raise ValueError("Can't have joiner without segments to join")
@ -152,7 +152,7 @@ class ExtractedText:
raise ValueError(f"Unexcepted segment joiner value {repr(value)}") raise ValueError(f"Unexcepted segment joiner value {repr(value)}")
@_text.validator @_text.validator
def check(self, _, value): def is_valid_text(self, _, value):
if value is None: if value is None:
return return
@ -166,7 +166,7 @@ class ExtractedText:
raise ValueError("Requires both text and grapheme clusters to be set") raise ValueError("Requires both text and grapheme clusters to be set")
@_grapheme_clusters.validator @_grapheme_clusters.validator
def check(self, _, value): def are_valid_grapheme_clusters(self, _, value):
if value is not None and self._text is None: if value is not None and self._text is None:
raise ValueError("Requires both text and grapheme clusters to be set") raise ValueError("Requires both text and grapheme clusters to be set")