🧹 dinglehopper: Move Python 3.5 XXXs to a GitHub issue

See https://github.com/qurator-spk/dinglehopper/issues/20.
pull/38/head
Gerber, Mike 5 years ago
parent 257e4986cc
commit a61c935624

@ -16,7 +16,6 @@ import unicodedata
class ExtractedText: class ExtractedText:
segments = attr.ib() segments = attr.ib()
joiner = attr.ib(type=str) joiner = attr.ib(type=str)
# TODO Use type annotations for attr.ib types when support for Python 3.5 is dropped
# TODO Types are not validated (attr does not do this yet) # TODO Types are not validated (attr does not do this yet)
@property @property

@ -10,7 +10,6 @@ from ..cli import process
def test_cli_json(tmp_path): def test_cli_json(tmp_path):
"""Test that the cli/process() yields a loadable JSON report""" """Test that the cli/process() yields a loadable JSON report"""
# XXX Path.__str__() is necessary for Python 3.5
with working_directory(str(tmp_path)): with working_directory(str(tmp_path)):
with open('gt.txt', 'w') as gtf: with open('gt.txt', 'w') as gtf:
gtf.write('AAAAA') gtf.write('AAAAA')
@ -26,7 +25,6 @@ def test_cli_json(tmp_path):
def test_cli_json_cer_is_infinity(tmp_path): def test_cli_json_cer_is_infinity(tmp_path):
"""Test that the cli/process() yields a loadable JSON report when CER == inf""" """Test that the cli/process() yields a loadable JSON report when CER == inf"""
# XXX Path.__str__() is necessary for Python 3.5
with working_directory(str(tmp_path)): with working_directory(str(tmp_path)):
with open('gt.txt', 'w') as gtf: with open('gt.txt', 'w') as gtf:
gtf.write('') # Empty to yield CER == inf gtf.write('') # Empty to yield CER == inf

@ -17,8 +17,6 @@ data_dir = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'data')
def test_ocrd_cli(tmp_path): def test_ocrd_cli(tmp_path):
"""Test OCR-D interface""" """Test OCR-D interface"""
# XXX Path.str() is necessary for Python 3.5
# Copy test workspace # Copy test workspace
test_workspace_dir_source = Path(data_dir) / 'actevedef_718448162' test_workspace_dir_source = Path(data_dir) / 'actevedef_718448162'
test_workspace_dir = tmp_path / 'test_ocrd_cli' test_workspace_dir = tmp_path / 'test_ocrd_cli'

Loading…
Cancel
Save